LIMS-2103: Display message for eBIC shipments if they try to access shipments#1039
Open
LIMS-2103: Display message for eBIC shipments if they try to access shipments#1039
Conversation
Collaborator
|
This will hide the 'Add Shipment' for any proposal that ever uses eBIC, but some (eg nr27313) might use both MX and eBIC. So maybe leave the button and the warning? |
Collaborator
Author
Good point, I'll remove the button.hide() call |
Collaborator
|
Is it also worth checking that $redirects has an "em" value before showing the banner? That way if someone else uses this code they wouldn't see this code. |
ndg63276
reviewed
Mar 2, 2026
Co-authored-by: Mark W <24956497+ndg63276@users.noreply.github.com>
ndg63276
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2103
Summary:
if eBIC users go to /shipments, they will find the page now displays text asking them to go to SCAUP, as this is the preferred way of defining those moving forward (for eBIC).
Changes:
To test: